This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: VxWorks Patches Back from the Dead!
- From: Bruce Korb <bkorb at gnu dot org>
- To: rbmj <rbmj at verizon dot net>
- Cc: gcc-patches at gcc dot gnu dot org, bonzini at gnu dot org, nathan at codesourcery dot com
- Date: Mon, 10 Sep 2012 12:46:13 -0700
- Subject: Re: VxWorks Patches Back from the Dead!
- References: <503573B9.5090406@verizon.net> <50357EC8.3000709@gnu.org> <5037CD07.6020704@verizon.net> <5037DAA3.3080604@gnu.org> <5037E216.1040301@verizon.net> <CAKRnqNK=26wXrJtCvLDSeQ=6UMP45rdWERGFqMuQf+JrqAiWcg@mail.gmail.com> <50399984.1030405@verizon.net> <503F6AFD.4050005@verizon.net> <CAKRnqNKJ71WRCVZFaJb9rOVouHf8L5FPJHg2sweU8a+LYeE_oQ@mail.gmail.com> <5042DC25.4060608@verizon.net> <504CBB9F.5070000@verizon.net> <504DECB4.1020505@gnu.org> <504E27EC.8030404@verizon.net>
Hi,
On Mon, Sep 10, 2012 at 10:48 AM, rbmj <rbmj@verizon.net> wrote:
> On the other hand, I've read this on the website:
>
>> Don't mix together changes made for different reasons. Send them
>> individually. Ideally, each change you send should be impossible to
>> subdivide into
>
> parts that we might want to consider separately, because each of its parts
> gets its motivation from the other parts
OTOH, this is a fairly cohesive set of patches.
A single project. Even if, strictly speaking, each include fix
is entirely separate from the others (by the design of fixincludes),
I see them as a cohesive set that ought to be in a single commit.
Fixes to fixes for fixincludes have been very infrequent.
> ... At the same
> time, it's a pain in the rear to worry about 12 different commits
I'm into comforting one's derriere.
> Unless cosmic rays break everything again, that should be all.
:) OK. I'll push it on your behalf once the other bits have been
approved by their approvers.
Cheers - Bruce