This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [ping][PATCH] Power: Reorder a sign-extend RTL pattern for readability
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, James Lemke <jwlemke at codesourcery dot com>
- Date: Sat, 8 Sep 2012 08:28:05 -0400
- Subject: Re: [ping][PATCH] Power: Reorder a sign-extend RTL pattern for readability
- References: <alpine.DEB.1.10.1208101321280.20608@tp.orcam.me.uk> <alpine.DEB.1.10.1209080120160.28358@tp.orcam.me.uk>
While examining the Power MD file seeking the explanation for a problem I
saw I have noticed a change in the past separated one of the instruction
splitters from its corresponding instruction pattern. Several unrelated
patterns were inserted between the two, presumably by accident where the
`patch' tool applied a diff made from an older or modified tree in the
wrong place.
I find this arrangement confusing, so I propose to move the splitter
back, next to the other pattern. Here's the intended update. No
functional change. OK to apply?
2012-08-10 Maciej W. Rozycki <macro@codesourcery.com>
gcc/
* config/rs6000/rs6000.md: Move a splitter next to its insn.
This patch is okay. Yes, the splitter should not have been separated
from the basic pattern. Thanks for helping to clean up the port.
Thanks, David