This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] New command line switch -fada-spec-parent
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Thomas Quinot <quinot at adacore dot com>
- Cc: Steven Bosscher <stevenb dot gcc at gmail dot com>, <gcc-patches at gcc dot gnu dot org>, <charlet at adacore dot com>
- Date: Fri, 7 Sep 2012 18:54:09 +0000
- Subject: Re: [PATCH] New command line switch -fada-spec-parent
- References: <20120824163335.GI7525@melamine.cuivre.fr.eu.org> <CABu31nMuqyP+_XD94UUkojoOjKFrMP3v-cANa-KYNB1g09Ybng@mail.gmail.com> <20120907151034.GB84237@melamine.cuivre.fr.eu.org>
On Fri, 7 Sep 2012, Thomas Quinot wrote:
> * c-family/c.opt (-fada-spec-parent): Define new command line switch.
> * c-family/c-ada-spec.c (get_ada_package): When -fada-spec-parent
> is specified, generate binding spec as a child of the specified unit.
c-family has its own ChangeLog.
> + int plen;
Use size_t rather than int for this length.
> + plen = strlen(ada_specs_parent) + 1;
Missing space before '('.
> + strcpy(res, ada_specs_parent);
Likewise.
> + res [plen - 1] = '.';
Stray space before '['.
OK with those issues fixed.
--
Joseph S. Myers
joseph@codesourcery.com