This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [middle-end] Add machine_mode to address_cost target hook
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: Oleg Endo <oleg dot endo at t-online dot de>, Georg-Johann Lay <gjl at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, law at redhat dot com, aoliva at redhat dot com, nickc at redhat dot com, geoffk at geoffk dot org, dje dot gcc at gmail dot com, joern dot rennecke at embecosm dot com, richard dot earnshaw at arm dot com, paul at codesourcery dot com, ramana dot radhakrishnan at arm dot com, eager at eagercon dot com, rdsandiford at googlemail dot com
- Date: Tue, 4 Sep 2012 16:32:18 +0200
- Subject: Re: [middle-end] Add machine_mode to address_cost target hook
- References: <1346287598.2407.90.camel@yam-132-YW-E178-FTW> <87hariaz1y.fsf@talisman.home> <1346505654.2200.25.camel@yam-132-YW-E178-FTW> <87wr0c6dst.fsf@talisman.home> <504335BD.7030701@gcc.gnu.org> <1346630332.2200.58.camel@yam-132-YW-E178-FTW> <1346745157.2322.14.camel@yam-132-YW-E178-FTW> <5045DA42.3080704@gnu.org>
On Tue, Sep 4, 2012 at 12:38 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
> Il 04/09/2012 09:52, Oleg Endo ha scritto:
>> [x] target-independent bits
>> [ ] alpha [ ] arm [ ] avr [ ] bfin
>> [ ] cr16 [ ] cris [ ] epiphany [ ] i386
>> [ ] ia64 [ ] iq2000 [ ] lm32 [ ] m32c
>> [ ] m32r [ ] mcore [ ] mep [x] microblaze
>> [x] mips [ ] mmix [x] mn10300 [ ] pa
>> [ ] rs6000 [ ] rx [ ] s390 [ ] score
>> [x] sh [ ] sparc [ ] spu [ ] stormy16
>> [ ] v850 [ ] vax [ ] xtensa
>>
>> Tested with 'make all-gcc' on SH xgcc and i386 native build.
>> No functional changes, except on MIPS, as requested by Richard
>> Sandiford.
>
> I think you only need explicit approval for mn10300. All other changes
> are trivial.
>
>> +hook_int_rtx_mode_as_bool_0 (rtx, enum machine_mode, addr_space_t, bool)
>
> So we're using C++ already? Or do we want ATTRIBUTE_UNUSED here?
Use C++ where it is so nicely obvious an improvement ;)
Richard.
> Paolo