This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, M68K] Fix ICE from scheduler improvement


Maxim Kuvyrkov <maxim_kuvyrkov@mentor.com> writes:

> 2012-09-03  Maxim Kuvyrkov  <maxim@codesourcery.com>
>
> 	* config/m68k/m68k.c (m68k_sched_dfa_post_advance_cycle): Fix ICE
> 	caused by "save scheduler state" patch.

The change log entry should describe what was changed.  "Save scheduler
state" doesn't say anything to me.

> +	{
> +	  /* The instruction buffer appears to be more filled than we
> +	     anticipated.  We should have inheritted the state from

s/inheritted/inherited/

> +	     the previous basic block.  Adjust buffer counter.  */
> +	  ++sched_ib.filled;
> +	}

The comment appears to suggest that this is rather a workaround for a
deficiency elsewhere.  Is that true?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]