This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR 54409] Remapping inlining predicates fix
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Fri, 31 Aug 2012 10:49:37 +0200
- Subject: Re: [PATCH, PR 54409] Remapping inlining predicates fix
- References: <20120830221857.GE3395@virgil.arch.suse.de>
> Hi,
>
> this patch fixes PR 54409. The condition for dealing with offset maps
> when remapping predicates which I have added recently was wrong,
> fortunately a subsequent assert caught this. We cannot shift stuff by
> an offset when it is passed by value.
>
> Conversely, the condition was unnecessarily restrictive, we can still
> happily use non-aggregate and by-value conditions when offset map is
> negative, that only means that by-ref stuff is not guaranteed to
> survive.
Yeah, I wondered about this ;)
>
> Bootstrapped and tested on x86_64-linux. OK for trunk?
>
> Thanks,
>
> Martin
>
>
>
> 2012-08-30 Martin Jambor <mjambor@suse.cz>
>
> PR middle-end/54409
> * ipa-inline-analysis.c (remap_predicate): Fix the offset_map
> checking condition.
>
> * gcc/testsuite/gcc.dg/torture/pr54409.c: New test.
OK,
thanks
Honza