This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google] Modification of gcov pmu format to reduce gcda size bloat (issue 6427063)
- From: davidxl at google dot com
- To: cmang at google dot com, tejohnson at google dot com, xur at google dot com
- Cc: gcc-patches at gcc dot gnu dot org, reply at codereview-hr dot appspotmail dot com
- Date: Fri, 24 Aug 2012 22:30:29 +0000
- Subject: Re: [google] Modification of gcov pmu format to reduce gcda size bloat (issue 6427063)
- Reply-to: cmang at google dot com, tejohnson at google dot com, xur at google dot com, davidxl at google dot com, gcc-patches at gcc dot gnu dot org, reply at codereview-hr dot appspotmail dot com
http://codereview.appspot.com/6427063/diff/11002/gcc/gcov-io.h
File gcc/gcov-io.h (right):
http://codereview.appspot.com/6427063/diff/11002/gcc/gcov-io.h#newcode688
gcc/gcov-io.h:688: gcov_unsigned_t index; /* The corresponding string
table index */
Is this field necessary?
http://codereview.appspot.com/6427063/diff/11002/gcc/gcov-io.h#newcode689
gcc/gcov-io.h:689: char* filename; /* The filename that belongs
at this index */
Can this field name be generalized?
http://codereview.appspot.com/6427063/diff/11002/libgcc/pmu-profile.c
File libgcc/pmu-profile.c (right):
http://codereview.appspot.com/6427063/diff/11002/libgcc/pmu-profile.c#newcode83
libgcc/pmu-profile.c:83:
Who is the caller to this interface?
It should be declared in gcov-io.h
http://codereview.appspot.com/6427063/