This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] more efficient mersenne_twister_engine::discard

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Ulrich Drepper <drepper at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 22 Aug 2012 16:10:21 +0200
Subject: Re: [PATCH] more efficient mersenne_twister_engine::discard
References: <CAOPLpQcwKhLc4iqgDL+6m5Mf21p8P5QJkZYy0f49bSwnFw6LnA@mail.gmail.com>

On 08/22/2012 03:43 PM, Ulrich Drepper wrote:

The discard member function of the mersenne_twister_engine class is
unnecessarily inefficient.   It currently discard elements one-by-one.
  It is possible to discard with higher granularity by discarding the
entire internal buffer.  The attached patch implements this.  To avoid
duplication a new internal member function is introduced which
generates a new set of bits for the internal buffer.  The operator()
is changed to use it.

Great, thanks. By the way, I suspect that other discard member functions could be also improved (nobody touched the code since the initial implementation when all where some sort of trivial conforming implementation)

Paolo.

References:
- [PATCH] more efficient mersenne_twister_engine::discard
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]