This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix some leaks and one uninitialized var read
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 22 Aug 2012 11:05:58 +0200
- Subject: Re: [PATCH] Fix some leaks and one uninitialized var read
- References: <20120821203350.GQ1999@tucnak.redhat.com>
On Tue, Aug 21, 2012 at 10:33 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> The recent change in find_assert_locations from XCNEWVEC to XNEWVEC
> caused a valgrind warning, because bb_rpo[ENTRY_BLOCK] used to
> be accessed, but was never initialized.
Sorry for this breakage. I looked at each of the changes carefully to
convince myself that XNEWVEC instead of XCNEWVEC wouldn't introduce
this kind of problem, but I overlooked that
pre_and_rev_post_order_compute is called with
include_entry_exit==false.
Ciao!
Steven