Re: dwarf2out.c: For DWARF 4+, output DW_AT_high_pc as constant offset.

[Mark Wielaard <mjw at redhat dot com>]

On Fri, Apr 27, 2012 at 08:16:04PM +0200, Mark Wielaard wrote:
> On Fri, 2012-04-27 at 15:43 +0200, Jakub Jelinek wrote:
> > On Fri, Apr 27, 2012 at 03:36:56PM +0200, Mark Wielaard wrote:
> > > But even without this, I think the patch is worth it just to get rid of
> > > all the relocations necessary otherwise.
> > 
> > IMHO we should defer applying this by a few months, given that GDB support
> > is only being added these days and -gdwarf-4 is now the default.
> > Applying it in August/September when there is already GDB version with
> > the support would be better.
> 
> OK, I'll try to remember and ping as soon as a new GDB release is out
> with the patch in.

Ping. There are stable releases of GDB 7.5, valgrind 3.8.0 and
elfutils 0.154 out now that support it.

I rebased the patch and tested against GDB 7.5.

2012-08-20  Mark Wielaard  <mjw@redhat.com>

    * dwarf2out.h (enum dw_val_class): Add dw_val_class_high_pc.
    * dwarf2out.c (dw_val_equal_p): Handle dw_val_class_high_pc.
    (add_AT_low_high_pc): New function.
    (AT_lbl): Handle dw_val_class_high_pc.
    (print_die): Likewise.
    (attr_checksum): Likewise.
    (attr_checksum_ordered): Likewise.
    (same_dw_val_p): Likewise.
    (size_of_die): Likewise.
    (value_format): Likewise.
    (output_die): Likewise.
    (gen_subprogram_die): Use add_AT_low_high_pc.
    (add_high_low_attributes): Likewise.
    (dwarf2out_finish): Likewise.

OK to commit now?

Thanks,

Mark

Attachment: high_pc.patch
Description: Text document