This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Google 4.7] Generate pubnames compatible with gdb-index version 7. (issue6459099)
- From: Cary Coutant <ccoutant at google dot com>
- To: Sterling Augustine <saugustine at google dot com>
- Cc: reply at codereview dot appspotmail dot com, gcc-patches at gcc dot gnu dot org
- Date: Thu, 16 Aug 2012 17:32:51 -0700
- Subject: Re: [Google 4.7] Generate pubnames compatible with gdb-index version 7. (issue6459099)
- References: <20120816235247.DEDE11609D0@sterling.mtv.corp.google.com>
> +/* Output a single entry in the pubnames table. */
> +
> +static void
> +output_pubname (dw_offset die_offset, pubname_entry *entry)
For this function, I'd suggest a comment to the effect that the logic
is lifted from GDB.
> @@ -2424,6 +2424,10 @@ gpubnames
> Common RejectNegative Var(debug_generate_pub_sections, 1)
> Generate DWARF pubnames and pubtypes sections.
>
> +ggnu-pubnames
> +Common RejectNegative Var(debug_generate_pub_sections, 2)
> +Generate DWARF pubnames and pubtypes sections.
Instead of "RejectNegative", I think these three options should now
use "Negative(...)" flags (each one naming the next, circularly). Not
sure about that, though. (See the treatment of -gdwarf-, -gstabs,
etc.)
OK for google/gcc-4_7 branch.
-cary