Re: [bootstrap] Tentative fix for PR 54281

[Diego Novillo <dnovillo at google dot com>]

On 12-08-16 09:08 , Richard Guenther wrote:
> On Thu, 16 Aug 2012, Diego Novillo wrote:
>
> > Richi, this implements your idea for fixing PR 54281.  I don't
> > have an old enough compiler.  Could you please test it in your
> > system?
> >
> > I debated whether to remove the GENERATOR_FILE predicate from the
> > inclusion (some files include gmp.h unconditionally).  I think it
> > could be removed, but only a minority of files build with
> > GENERATOR_FILE set, so it didn't seem harmful.
> >
> > OK if tests pass?
>
> It fixes it.
>
> Thus, ok from my side (if your testing succeeds).

So, I had failed to include Ada in my testing and my patch breaks it. 
In several ada/*.c files, we forcefully include system.h as a C header:

#ifdef __cplusplus
extern "C" {
#endif
...
#include "system.h"
...
#ifdef __cplusplus
}
#endif


Eric, is this really needed now?  We are including gmp.h from system.h 
due to PR 54281.  This is causing Ada builds to fail.

Would it be OK to remove all the '#ifdef __cplusplus' conditionals from 
ada/*.c or is there something I'm missing?


Thanks.  Diego.