This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Merge C++ conversion into trunk (4/6 - hash table rewrite)


Hi,

On Wed, 15 Aug 2012, Richard Guenther wrote:

> Like the following, only the coverage.c use is converted.  I've never 
> seen template function arguments anywhere and having to repeat them all 
> over the place is really really ugly (yes, even if only in the 
> implementation).
> 
> This goes with static member functions and not wrapping any data. It 
> goes away with the requirement of having externally visible global 
> functions for the hash/compare functions as well (which was ugly 
> anyway).
> 
> Comments?

Well, it looks nicer than what's there currently.  As the element 
functions now are scoped and normal member functions, they should be named 
with lower case characters of course.  I do like that the hash table would 
then only have one real template argument; the Allocator, well, no better 
idea comes to my mind.


Ciao,
Michael.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]