This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Use gcc_checking_assert in dominance.c
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 14 Aug 2012 12:06:57 +0200
- Subject: Re: [patch] Use gcc_checking_assert in dominance.c
- References: <CABu31nP=ZcC0vDQ_HDFOw7uSJU-OCYxL2Nw-MH5G8ugLYbfQ0A@mail.gmail.com>
On Tue, Aug 14, 2012 at 12:03 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> Hello,
>
> Checking overhead in dominance.c gives measurable compile time
> increases on a set of cc1-i files. Most of the checking should be done
> only with non-release checks enabled.
>
> Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk?
Ok with combining asserts into one here
+ gcc_checking_assert (dir == CDI_DOMINATORS);
+ gcc_checking_assert (dom_computed[dir_index]);
and here
+ gcc_checking_assert (dom_computed[dir_index]);
+ gcc_checking_assert (!bb->dom[dir_index]);
Thanks,
Richard.