This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: "Fu, Chao-Ying" <fu at mips dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Maxim Kuvyrkov <maxim at codesourcery dot com>
- Date: Thu, 9 Aug 2012 18:58:14 +0000
- Subject: RE: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86
- References: <20120809163953.GA5322@intel.com> <7C6479EB2BF52547AC332FD6034646DA01448EB694@exchdb03.mips.com>
On Thu, 9 Aug 2012, Fu, Chao-Ying wrote:
> How about this patch? Just enable it for MIPS that provides link.h in Android NDK.
> Thanks a lot!
Please don't put this sort of architecture conditional in an
architecture-independent source file. In this case it should be fine for
libgcc's configure to try compiling a file that #includes <link.h>
(obviously, make sure the configure test gets the right results both when
it's present and when it's absent), and use the results of that configure
test instead of defined(__mips__). (In a bootstrap where libc headers
aren't yet present, inhibit_libc should be defined anyway to disable those
libgcc features depending on system headers from libc.)
--
Joseph S. Myers
joseph@codesourcery.com