This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: MIPS Android patch
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Maxim Kuvyrkov <maxim at codesourcery dot com>, "Chupin, Pavel V" <pavel dot v dot chupin at intel dot com>, Igor Zamyatin <izamyatin at gmail dot com>
- Cc: "Fu, Chao-Ying" <fu at mips dot com>, Richard Sandiford <rdsandiford at googlemail dot com>, gcc-patches Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 9 Aug 2012 08:56:53 -0700
- Subject: Re: MIPS Android patch
- References: <7C6479EB2BF52547AC332FD6034646DA01448CB550@exchdb03.mips.com> <3520BEE4-2FE1-4D3D-AA91-02265986C87B@codesourcery.com> <CAMe9rOo-dyrBNOn9Lfqv1ygNz+Bb4A+jTj4ccqjHY-GrSpvC4w@mail.gmail.com>
On Thu, Aug 9, 2012 at 8:45 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Apr 20, 2012 at 6:15 PM, Maxim Kuvyrkov <maxim@codesourcery.com> wrote:
>> On 20/04/2012, at 1:34 PM, Fu, Chao-Ying wrote:
>>
>>> Hi Maxim, Richard,
>>>
>>> I built cross-toolchains for 3 different targets as follows.
>>> 1. mips-linux-gnu
>>> 2. mips-linux-gnu --enable-targets=all
>>> 3. mips64-linux-gnu
>>>
>>> These targets are affected by this MIPS Android patch.
>>>
>>> Then, I checked the output from "gcc -dumpspecs" before and after applying the patch.
>>> The specs have 6 places of differences for Android due to new defines in linux-common.h.
>>> I am also building GCC natively, and will test GCC natively later.
>>> Any feedback? Thanks!
>>>
>>> Regards,
>>> Chao-ying
>>>
>>> libgcc/ChangeLog
>>> 2012-04-19 Chao-ying Fu <fu@mips.com>
>>>
>>> * unwind-dw2-fde-dip.c: Define USE_PT_GNU_EH_FRAME for BIONIC.
>>
>> This piece is trivial, so, given that Richard approved the MIPS changes, you are clear to check in after amending the patch per Richard's comments. Please check in the patch to unwind-dw2-fde-dip.c separately, as it is a change on its own.
>>
>> Thank you,
>>
>
> This breaks Android/x86 build:
>
> #if defined(USE_PT_GNU_EH_FRAME)
>
> #include <link.h>
>
> but Bionic/x86 doesn't have link.h
>
> --
> H.J.
I opened:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54209
--
H.J.