This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer
- From: Daniel Veillard <veillard at redhat dot com>
- To: Dodji Seketeli <dodji at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Tom Tromey <tromey at redhat dot com>, Andrew Haley <aph at redhat dot com>
- Date: Thu, 9 Aug 2012 08:16:24 +0800
- Subject: Re: [PATCH, libjava] Use accessor functions to manipulate xmlOutputBuffer
- References: <m3txwdvxyj.fsf@redhat.com>
- Reply-to: veillard at redhat dot com
On Thu, Aug 09, 2012 at 12:08:20AM +0200, Dodji Seketeli wrote:
> Hello,
>
> This is a fix to prepare the xmlj_io.c file of gnu classpath to a coming
> API change in libxml2.
>
> Basically, we were previously accessing fields inside the
> xmlOutputBuffer struct of libxml2. In a coming version of libxml2,
> that won't be possible anymore. Client code will have to use accessor
> functions instead. For the gory details, there is an interestin note
> of Daniel Veillard (author of libxml2) at
> https://mail.gnome.org/archives/desktop-devel-list/2012-August/msg00007.html.
>
> This patch defines too accessor macros that, depending on the version
> of libxml2 we are using will either access the fields of
> xmlOutputBuffer directly, or use the new accessor function.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu against trunk.
>
> OK to commit?
For the record, I rewieved the patch and it looks fine to me,
thanks Dodji !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/