This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Value type of map need not be default copyable

From: Ollie Wild <aaw at google dot com>
To: gcc-patches <gcc-patches at gcc dot gnu dot org>, paolo dot carlini at oracle dot com
Cc: Richard Smith <richardsmith at google dot com>, Diego Novillo <dnovillo at google dot com>, Paul Pluzhnikov <ppluzhnikov at google dot com>
Date: Thu, 2 Aug 2012 21:17:52 -0700
Subject: Value type of map need not be default copyable

Patch courtesy Richard Smith at Google:

Fix bug in the implementation of std::map's operator[]. Construct an
object of type value_type, rather than using std::make_pair, so as to
allow mapped_type to have an *explicit* copy constructor.

See [map.access] (23.4.4.3)/5 for the corresponding standardese.

Tested via bootstrap + test.

Okay for trunk?

Thanks,
Ollie


2012-08-02  Ollie Wild  <aaw@google.com>
	    Richard Smith  <richardsmith@google.com>

	* include/bits/stl_map.h (operator[](key_type&&)): Replace
	std::make_pair with value_type.
	* testsuite/23_containers/map/operators/2.cc: New test.

Attachment: patch.txt
Description: Text document

Follow-Ups:
- Re: Value type of map need not be default copyable
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]