Re: PING [PATCH] Fix PR libstdc++/54036, problem negating DFP NaNs

[Paolo Carlini <paolo dot carlini at oracle dot com>]

Hi,

On 08/02/2012 01:53 AM, Peter Bergner wrote:
> So just to be sure, like the patch below?
More or less. See comments below.
> Also, is this ok for the 4.6 and 4.7 release branches?
I don't think this is a regression, thus I would say 4.7 only, to be safe.
> Peter
>
>
> libstdc++-v3/
> 	PR libstdc++/54036
> 	* include/decimal/decimal.h (_DEFINE_DECIMAL_UNARY_OP): Use _Op as
> 	a unary operator.
>
> libstdc++-v3/testsuite/
> 	PR libstdc++/54036
> 	* decimal/pr54036-1.cc: New test.
> 	* decimal/pr54036-2.cc: Likewise.
> 	* decimal/pr54036-3.cc: Likewise.
we don't have a separate ChangeLog in libstdc++-v3/testsuite/. Thus a 
single ChangeLog entry for everything.
> Index: libstdc++-v3/include/decimal/decimal.h
> ===================================================================
> --- libstdc++-v3/include/decimal/decimal.h	(revision 189599)
> +++ libstdc++-v3/include/decimal/decimal.h	(working copy)
> @@ -288,7 +288,7 @@
>     inline _Tp operator _Op(_Tp __rhs)		\
>     {						\
>       _Tp __tmp;					\
> -    __tmp.__setval(0 _Op __rhs.__getval());	\
> +    __tmp.__setval(_Op __rhs.__getval());	\
>       return __tmp;				\
>     }
>   
> Index: libstdc++-v3/testsuite/decimal/pr54036-1.cc
> ===================================================================
> --- libstdc++-v3/testsuite/decimal/pr54036-1.cc	(revision 0)
> +++ libstdc++-v3/testsuite/decimal/pr54036-1.cc	(revision 0)
> @@ -0,0 +1,56 @@
Copyright blurb missing. Also, you need:

// { dg-require-effective-target dfp }

Likewise for the other testcases.

> +#include <decimal/decimal>
> +using namespace std;
> +
> +decimal::decimal32
> +__attribute__ ((noinline))
> +my_nan32 (void)
> +{
> +  decimal::decimal32 z = 0;
> +  decimal::decimal32 v = z/z;
> +  return v;
> +}
> +
> +decimal::decimal32
> +__attribute__ ((noinline))
> +my_inf32 (void)
> +{
> +  decimal::decimal32 o = 1;
> +  decimal::decimal32 z = 0;
> +  decimal::decimal32 v = o/z;
> +  return v;
> +}
> +
> +int
> +main (void)
> +{
> +  decimal::decimal32 v;
> +
> +  v = my_nan32 ();
> +  if (!__builtin_isnand32 (v.__getval ()))
> +    __builtin_abort ();
> +  if (__builtin_signbitd32 (v.__getval ()))
> +    __builtin_abort ();
> +
> +  v = -v;
> +
> +  if (!__builtin_isnand32 (v.__getval ()))
> +    __builtin_abort ();
> +  if (!__builtin_signbitd32 (v.__getval ()))
> +    __builtin_abort ();
> +
> +  v = my_inf32 ();
> +  if (!__builtin_isinfd32 (v.__getval ()))
> +    __builtin_abort ();
> +  if (__builtin_signbitd32 (v.__getval ()))
> +    __builtin_abort ();
> +
> +  v = -v;
> +
> +  if (!__builtin_isinfd32 (v.__getval ()))
> +    __builtin_abort ();
> +  if (!__builtin_signbitd32 (v.__getval ()))
> +    __builtin_abort ();
> +
> +  return 0;
> +}
> +
In the library testsuite we include:

#include <testsuite_hooks.h>

and then we use VERIFY not __builtin_abort. Also, for decimal, we 
normally use:

using namespace std::decimal.

Please have the other existing decimal floating point testcases as 
reference, for these details, please try to be consistent.

Also, watch out blank lines at the end of the testcases.

Paolo.