This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR 53528 c++/ C++11 Generalized Attribute support


On 07/26/2012 11:19 AM, Dodji Seketeli wrote:
+  struct scoped_attributes *ns = set_attributes_namespace (attrs,
+                                                          attrs_len,
+                                                          name_space);
+  if (ns == NULL)
+    return NULL;
+
+  for (i = 0; i < attrs_len; ++i)
+    register_scoped_attribute (&attrs[i], ns);

This looks kind of funny; setting their namespace and then registering them sound like the same thing. Let's rename set_attributes_namespace to register_scoped_attributes and call register_scoped_attribute from there.


+      if (TREE_STATIC (node))
+       {
+         /* For file scope variables and static members, the target
+            supports alignments that are at most
+            MAX_OFILE_ALIGNMENT.  */

I think this should check TREE_STATIC || DECL_EXTERNAL.


More later.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]