This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] Fix pastos (?) in make_typename_type calls

From: Jason Merrill <jason at redhat dot com>
To: Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Tue, 24 Jul 2012 14:06:56 -0400
Subject: Re: [C++ Patch] Fix pastos (?) in make_typename_type calls
References: <500EAFFC.8030703@oracle.com>

On 07/24/2012 10:23 AM, Paolo Carlini wrote:

while looking into the re-opened c++/51213 (doesn't seem trivial:
details soon, I hope) I noticed things which look like old pastos: in
convert_template_argument and tsubst we are computing complain &
tf_error for the - tsubst_flags_t, not bool - fourth argument of
make_typename_type. That doesn't make much sense to me and the below,
as-is, passes testing.

The point of this use of (complain & tf_error) is to mask out flags we don't want and leave only tf_error. It may or may not be needed, but it's not a pasto.

Jason

Follow-Ups:
- Re: [C++ Patch] Fix pastos (?) in make_typename_type calls
  - From: Paolo Carlini

References:
- [C++ Patch] Fix pastos (?) in make_typename_type calls
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]