This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/3] Fix 0 != CODE_FOR_nothing thinko

From: Richard Henderson <rth at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 19 Jul 2012 13:48:27 -0700
Subject: Re: [PATCH 1/3] Fix 0 != CODE_FOR_nothing thinko
References: <1342723978-30066-1-git-send-email-rth@redhat.com> <20120719203504.GG4807@tucnak.redhat.com>

On 07/19/2012 01:35 PM, Jakub Jelinek wrote:
> On Thu, Jul 19, 2012 at 11:52:56AM -0700, Richard Henderson wrote:
>> I discovered the vectorizable_operation while trying to figure out why
>> ia64 wasn't generating the mul_highpart pattern as I expected: we always
>> force CODE_FOR_nothing to 0.  Oops.
> 
> icode = 0; was chosen as something that wouldn't match a real insn, yet was
> different from CODE_FOR_nothing.  CODE_FOR_nothing changed to 0 only
> 10 days ago...  Thanks for spotting this.

Ah, good.  I thought I was just going crazy remembering C_F_N != 0.
I havn't gotten back as far as Steven's patch in my post-vacation mail queue yet...


r~

References:
- [PATCH 1/3] Fix 0 != CODE_FOR_nothing thinko
  - From: Richard Henderson
- Re: [PATCH 1/3] Fix 0 != CODE_FOR_nothing thinko
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]