This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Ada] Fix to 64-bit atomic operation failures on ppc-linux

From: Andrew MacLeod <amacleod at redhat dot com>
To: Arnaud Charlet <charlet at adacore dot com>
Cc: gcc-patches at gcc dot gnu dot org, Vincent Pucci <pucci at adacore dot com>
Date: Tue, 17 Jul 2012 07:57:09 -0400
Subject: Re: [Ada] Fix to 64-bit atomic operation failures on ppc-linux
References: <20120717101511.GA25996@adacore.com>

On 07/17/2012 06:15 AM, Arnaud Charlet wrote:

This patch fixes failures due to the use of 64-bit atomic
operations on ppc-linux. Undo of the previous patch for 64-bit atomic
operations only.

Note: this does NOT address the failure on ppc-darwin, which will be addressed
by another patch soon.

Tested on x86_64-pc-linux-gnu, committed on trunk

2012-07-17 Vincent Pucci <pucci@adacore.com>

	* s-atopri.adb (Lock_Free_Try_Write_X): Atomic_Compare_Exchange_X
	replaced by Sync_Compare_And_Swap_X.
	(Lock_Free_Try_Write_64): Removed.
	* s-atopri.ads (Sync_Compare_And_Swap_X): Replaces previous
	routine Atomic_Compare_Exchange_X.
	(Lock_Free_Read_64): Renaming of Atomic_Load_64.
	(Lock_Free_Try_Write_64): Renaming of Sync_Compare_And_Swap_64.

What is the nature of the atomic failures using the __atomic_compare_exchange built-in? Does it have anything to do with the expected value being returned by pointer?

Andrew

Follow-Ups:
- Re: [Ada] Fix to 64-bit atomic operation failures on ppc-linux
  - From: Richard Henderson

References:
- [Ada] Fix to 64-bit atomic operation failures on ppc-linux
  - From: Arnaud Charlet

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]