This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR bootstrap/53963: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, rguenther at suse dot de
- Date: Mon, 16 Jul 2012 10:09:00 +0200
- Subject: Re: PATCH: PR bootstrap/53963: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled
- References: <20120714184916.GA31238@intel.com>
On Sat, Jul 14, 2012 at 8:49 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Hi,
>
> Revision 189453:
>
> http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00357.html
>
> removes type attribute comparison in gimple_types_compatible_p_1 and
> caused PR middle-end/53959 and PR bootstrap/53963. This restores type
> attribute comparison. Tested on Linux/x86-64. OK to install?
Ok.
Thanks,
Richard.
> Thanks.
>
>
> H.J.
> ---
> 2012-07-14 H.J. Lu <hongjiu.lu@intel.com>
>
> PR middle-end/53959
> PR bootstrap/53963
> * gimple.c (gimple_types_compatible_p_1): Restore type attribute
> comparison.
>
> diff --git a/gcc/gimple.c b/gcc/gimple.c
> index b419591..4d2a0f5 100644
> --- a/gcc/gimple.c
> +++ b/gcc/gimple.c
> @@ -3422,6 +3422,10 @@ gimple_types_compatible_p_1 (tree t1, tree t2, type_pair_t p,
> goto different_types;
> }
>
> + /* If their attributes are not the same they can't be the same type. */
> + if (!attribute_list_equal (TYPE_ATTRIBUTES (t1), TYPE_ATTRIBUTES (t2)))
> + goto different_types;
> +
> /* Do type-specific comparisons. */
> switch (TREE_CODE (t1))
> {