This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix IPA with profiling


On Wed, 4 Jul 2012, Uros Bizjak wrote:

> Hello!
> 
> Attached patch partially reverts r187375 [1]. Apparently, the patch
> added some new functionality to symtab_remove_unreachable_nodes,
> although the ChangeLog said:
> 
> Log:
> 	...
> 	(symtab_remove_unreachable_nodes): Cleanup.
> 
> It looks to me that since we changed something, we also have to update
> something, at least when profiling, before calling
> cgraph_propagate_frequency.
> 
> 2012-07-04  Uros Bizjak  <ubizjak@gmail.com>
> 
> 	* ipa.c (symtab_remove_unreachable_nodes): Partially revert r187375
> 	to not call cgraph_propagate_frequency if something was changed.
> 
> testsuite/ChangLog:
> 
> 2012-07-04  Uros Bizjak  <ubizjak@gmail.com>
> 
> 	* g++.dg/torture/pr53321.C: New test.
> 
> Bootstrapped and regression tested on x86_64-pc-linux-gnu {,-m32},
> also with profiled LTO bootstrap.
> 
> OK for mainline?

Ok.

Thanks,
Richard.

> [1] http://gcc.gnu.org/ml/gcc-cvs/2012-05/msg00371.html
> 
> Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]