This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Ada] fix use of PICFLAG for Ada library variants


Hello Jakub,

On Jun 14, 2012, at 18:22 , Jakub Jelinek wrote:

>> 2012-06-10  Olivier Hainque  <hainque@adacore.com>
>> 
>>        * Makefile.in (GNATLIBCFLAGS_FOR_C): Remove $(PIC_FLAG_FOR_TARGET).

> You've apparently committed during 4.7 branch freeze a variant of this
> patch to the 4.7 branch as well, unfortunately it breaks ada bootstrap
> completely on x86_64-linux.

 Ug. Procedural mistake :-( Really, really sorry.

> While r188390 (trunk version) has in gnatlib-shared-default:
> 	GNATLIBCFLAGS_FOR_C="$(GNATLIBCFLAGS_FOR_C) $(PICFLAG_FOR_TARGET)" \
> r188462 (4.7 version) doesn't have there $(PICFLAG_FOR_TARGET). 

 Indeed, and it should as soon as picflag is not in the other variable.

 How do you want me to proceed: 

 Simply revert and leave the original problem in, or fix things up ?

 I'll double checking that bootstrap unbreaks in either case, of course.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]