This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] lib/dg-pch.exp: distinguish between two compilations in summary
On Jun 13, 2012, at 2:59 PM, Joseph S. Myers wrote:
> On Wed, 13 Jun 2012, Janis Johnson wrote:
>
>> The patch for PR20771 did fix the problem (so I should have closed it)
>> but it was undone as part of a later change to the same lines. I could
>> either do that again, with comments this time explaining why they are
>> slightly different, or use "-Dwith_PCH" and "-Dwithout_PCH" in the flags
>> that will appear in the test summary. Do you have a preference?
>
> I have no preference here.
Ok for mainline. My only preference was to have a comment above the line that has the -D flag telling why. You have that in your patch, so I'm happy. If you want to use -Dwith_PCH, I'm fine with either spelling.