This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)
On Wed, Jun 6, 2012 at 3:49 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Mon, Jun 4, 2012 at 7:53 PM, Sterling Augustine
> <saugustine@google.com> wrote:
>> On Fri, Jun 1, 2012 at 4:38 PM, Gabriel Dos Reis
>> <gdr@integrable-solutions.net> wrote:
>>> On Fri, Jun 1, 2012 at 6:07 PM, Sterling Augustine
>>> <saugustine@google.com> wrote:
>>>> After finding yet another bug in the previous patch dealing with pretty-printing
>>>> decls for dwarf in canonical form, I have figured out a way to do it that is
>>>> less invasive and much cleaner.
>>>>
>>>> This updated patch simply wraps the two entry points into the decl pretty-
>>>> printer called from cxx_dwarf_name with new functions that set the
>>>> appropriate flag on the pretty printer. This is much cleaner and avoids
>>>> the need for translating flags for C++ pretty-printing into standard C
>>>> pretty printing flags.
>>>>
>>>> OK for mainline?
>>>
>>> OK.
>>
>> Thanks! Committed as posted.
>
> With a wrong ChangeLog:
>
> ? ? ? ?* gcc/c-family/c-pretty-print.h (pp_c_flag_gnu_v3): New enumerator.
> ? ? ? ?* gcc/c-family/c-pretty-print.c (pp_c_specifier_qualifier_list): Check
> ? ? ? ?it at both the start and end of the function.
> ? ? ? ?* gcc/cp/error.c (dump_decl): Check pp_c_flag_gnu_v3.
> ? ? ? ?(decl_as_dwarf_string, lang_decl_dwarf_name): New functions.
> ? ? ? ?(lang_decl_name): Handle namespace decls.
> ? ? ? ?* gcc/cp/cp-tree.h: Declare decl_as_dwarf_string, lang_decl_dwarf_name.
> ? ? ? ?* gcc/cp/cp-lang.c: Call them.
>
> Changes for files in gcc/ go in gcc/ChangeLog.
> Changes for files in gcc/cp go in gcc/cp/ChangeLog.
> Changes for files in gcc/c-family go in gcc/c-family/ChangeLog.
>
> The path is not pre-fixed. So:
>
> c-family/
> ? ? ? ?* c-pretty-print.h (pp_c_flag_gnu_v3): New enumerator.
> ? ? ? ?* c-pretty-print.c (pp_c_specifier_qualifier_list): Check
> ? ? ? ?it at both the start and end of the function.
>
> cp/
> ? ? ? ?* error.c (dump_decl): Check pp_c_flag_gnu_v3.
> ? ? ? ?(decl_as_dwarf_string, lang_decl_dwarf_name): New functions.
> ? ? ? ?(lang_decl_name): Handle namespace decls.
> ? ? ? ?* cp-tree.h: Declare decl_as_dwarf_string, lang_decl_dwarf_name.
> ? ? ? ?* cp-lang.c: Call them.
>
> Can you please fix this?
> You don't have to post such patches for review.
Fixes committed as you recomend.
FWIW, the original entries were generated with contrib/mklog. Someone
may want to fix it to do the right thing in this case.