This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC] Extend memset recognition
Hi,
On Thu, 31 May 2012, Richard Guenther wrote:
> > Bootstrapped (with memset recognition enabled by default) and tested
> > on x86_64-unknown-linux-gnu with the aforementioned issues.
>
> The following fixes it by simply always adding
> -fno-tree-loop-distribute-patterns to builtins.exp.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu.
>
> If there are no further comments I'll go with the local advise from
> Micha who says "who cares".
To be honest, the long version of "who cares" was rather:
M "well we could disallow generating calls to X in functions named X",
handling some easy cases;
R "but user could write my_memcpy, and use an alias to it named memcpy
from another unit";
M "so, he shouldn't do that, or disable such pattern recognition";
R "we could also only rewrite in AVAIL_LOCAL function";
M "huh, disables quite many things except for lto, ... my benchmarks ...";
R "hmm"
M "hmm"
...
M "who cares"
;)
Ciao,
Michael.