This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [cxx-conversion] New Hash Table (issue6244048)
On Fri, May 25, 2012 at 7:17 AM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Fri, 25 May 2012, Jakub Jelinek wrote:
>
>> > + ?/* Return the current size of this hash table. ?*/
>> > +
>> > + ?size_t size()
>> > + ?{
>> > + ? ?return htab->size;
>> > + ?}
>>
>> (and various other places) - formatting is wrong, missing space between (.
>
> And it doesn't start at the first column, and type isn't on a separate
> line. ?I realize that this is a member method, hence indenting and C GNU
> coding standards conflict, but the latter do have some nice properties
> (for instance that 'grep ^func_name *.c' finds only the definition, not
> all the calls to func_name).
>
> I think we need a discussion about style, now that actually people are
> working on this.
Note also the almost 2 decades of C++ style practice in our libstdc++
implementation.
-- Gaby