Re: [AARCH64] [PATCH 3/3] AArch64 Port

[Steven Bosscher <stevenb dot gcc at gmail dot com>]

On Fri, May 25, 2012 at 1:19 PM, Marcus Shawcroft
<marcus.shawcroft@arm.com> wrote:
> This patch adds an implementation of integer iterators.
>
> Index: gcc/ChangeLog.aarch64
>
> ? ? ? ?* read-rtl.c (rtx_list): New data structure.
> ? ? ? ?(int_iterator_mapping): New data structure.
> ? ? ? ?(int_iterator_data): New. List of int iterator details.
> ? ? ? ?(num_int_iterator_data): New.
> ? ? ? ?(ints): New group list.
> ? ? ? ?(find_int): New. Find an int iterator in a list.
> ? ? ? ?(dummy_uses_int_iterator): Dummy handle.
> ? ? ? ?(dummy_apply_int_iterator): Dummy handle.
> ? ? ? ?(uses_int_iterator_p): New.
> ? ? ? ?(apply_iterator_to_rtx): Handle case for rtx field specifier 'i'.
> ? ? ? ?(initialize_iterators): Initialize int iterators data struts.
> ? ? ? ?(find_int_iterator): New. Find an Int iterators from a hash-table.
> ? ? ? ?(add_int_iterator: Add int iterator to database.
> ? ? ? ?(read_rtx): Parse and read int iterators mapping and attributes.
> ? ? ? ?Initialize int iterators group's hash-table. Memory management.
> ? ? ? ?(read_rtx_code): Handle case for rtl field specifier 'i'.

Hello,

Can you please use diff -up (or svn diff -x -up) when you post a
patch? With -p it is easier to see what functions you have modified.

Can you please add documentation for this new iterator (I suppose in
doc/md.texi??).

> @@ -480,6 +563,7 @@
>
>    iterator = (struct mapping *) *slot;
>    for (elem = mtd->queue; elem != 0; elem = XEXP (elem, 1))
> +  {
>      if (uses_iterator_p (XEXP (elem, 0), iterator))
>        {
>  	/* For each iterator we expand, we set UNKNOWN_MODE_ATTR to NULL.
> @@ -509,6 +593,7 @@
>  	    XEXP (elem, 0) = x;
>  	  }
>      }
> +  }
>    return 1;
>  }

Not sure what this change is for. In any case, indentation does not
conform to GCC coding conventions (I don't think everyone is
particularly fond of them, but we should follow them nonetheless ;-)

Ciao!
Steven