This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google/google-main] Fix regression - SUBTARGET_EXTRA_SPECS overridden by LINUX_GRTE_EXTRA_SPECS (issue 6016047)
- From: Han Shen(ææ) <shenhan at google dot com>
- To: shenhan at google dot com, asharif at google dot com, jingyu at google dot com, dnovillo at google dot com, xur at google dot com, gcc-patches at gcc dot gnu dot org, reply at codereview-hr dot appspotmail dot com, Luis Lozano <llozano at google dot com>, Yunlian Jiang <yunlian at google dot com>, Caroline Tice <cmtice at google dot com>
- Date: Wed, 16 May 2012 10:16:13 -0700
- Subject: Re: [google/google-main] Fix regression - SUBTARGET_EXTRA_SPECS overridden by LINUX_GRTE_EXTRA_SPECS (issue 6016047)
- References: <20cf305643ad51525004c01ab101@google.com>
Hi Jing, thanks!
The SUBTARGET_EXTRA_SPECS is defined in config/i386/gnu-user.h
In "linux.h", the original value of "SUBTARGET_EXTRA_SPECS" is
overwritten by LINUX_GRTE_EXTRA_SPECS, which is not right! Instead,
"SUBTARGET_EXTRA_SPECS" and "LINUX_GRTE_EXTRA_SPECS" must be
concatenated.
For every target, "SUBTARET_EXTRA_SPECS" has its own value, for
example, for darwin, darwin.h just redefines SUBTARGET_EXTRA_SPECS, so
the patch does not affect targets other than i386.
Regards,
-Han
On Tue, May 15, 2012 at 3:26 PM, <jingyu@google.com> wrote:
>
> I suspect this patch would change specs of non-i386 platform. For
> example, LINUX_GRTE_EXTRA_SPECS is not part of SUBTARGET_EXTRA_SPECS for
> darwin.
>
> Can you tell where SUBTARGET_EXTRA_SPECS is firstly defined for chromeos
> toolchain?
>
>
>
>
> On 2012/05/14 18:32:17, shenhan wrote:
>>
>> On 2012/04/12 21:14:29, shenhan wrote:
>> > Hi, the newest chrome gcc (from google-main) fails to linking
>
> anything, by
>>
>> > looking into specs file, it seems that 'link_emulation' section is
>
> missing in
>>
>> > specs.
>> >
>> > The problem I found is that SUBTARGET_EXTRA_SPECS, which is not
>
> empty for
>>
>> > chromeos, is overridden by "LINUX_GRTE_EXTRA_SPECS".
>> >
>> > Please review the proposed a patch. (Tested by buildit bootstrap).
>> >
>> > -Han
>
>
>> Hi Jing and Rong, could you take a look at this?
>
>
>> Thanks,
>> -Han
>
>
>
>
> http://codereview.appspot.com/6016047/
--
Han Shen?| ?Software Engineer?| ?shenhan@google.com?| ?+1-650-440-3330