This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Caret diagnostics
On Sun, Apr 8, 2012 at 11:13 AM, Manuel LÃpez-IbÃÃez
<lopezibanez@gmail.com> wrote:
> On 8 April 2012 06:09, Jason Merrill <jason@redhat.com> wrote:
>> On 04/07/2012 06:29 PM, Manuel LÃpez-IbÃÅez wrote:
>>
>>> +getenv_columns (void)
>>
>>
>> I had been thinking to check COLUMNS once at the beginning of compilation; I
>> don't think the value can change while the compiler is running since we
>> don't respond to SIGWINCH. ÂAnd let's use this value in
>> c_common_initialize_diagnostics, too.
>>
>
> To focus on the issue at hand, and independently of whether any bugs
> exist or not, and whether I am capable or not to fix them. What you
> are proposing is to change the current default of no line-wrapping to
> line-wrap at getenv("COLUMNS"), isn't it?
yes.
> And then, to use the same
> value for the max_width in the function printing the caret, is that
> correct?
yes.
>
> Cheers,
>
> Manuel.