This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: remove wrong code in immed_double_const


On Mar 26, 2012, at 1:03 PM, Richard Sandiford wrote:
> I think:
> 
> ...copies of the top bit.  Note however that values are neither inherently
> signed nor inherently unsigned; where necessary, signedness is determined
> by the rtl operation instead.

Sounds good to me, changed.

> Same idea here.

Fixed.

>> +/* Return an rtx for the sum of X and the integer C, given that X has
>> +   mode MODE.  This routine should be used instead of plus_constant
>> +   when they want to ensure that addition happens in a particular
>> +   mode, which is necessary when x can be a VOIDmode CONST_INT or
> 
> Sorry, just noticed, should be "...when X can be..."

Fixed.

Richard has ok all his bits, now down to you for final ok.

Ok?

Attachment: oi-trunk-2.diffs.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]