This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Bug fix in store_bit_field_1 for big endian targets (issue 51893)
- From: Alan Modra <amodra at gmail dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: Aurelien Buhrig <aurelien dot buhrig dot gcc at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 23 Mar 2012 14:09:30 +1030
- Subject: Re: [PATCH] Bug fix in store_bit_field_1 for big endian targets (issue 51893)
- References: <4F69979E.4070502@gmail.com> <201203212253.07335.ebotcazou@adacore.com>
On Wed, Mar 21, 2012 at 10:53:07PM +0100, Eric Botcazou wrote:
> > This patch (for 4.6) fixes a wrong subword index computation in
> > store_bit_field_1 for big endian targets when value is at least 4 times
> > bigger than a word (DI REG value with HI words).
> >
> > It fixes a regression on gcc.c-torture/execute/bitfld-3.c for my current
> > backend port.
> >
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51893
> >
> > OK to commit?
>
> It is OK for mainline on principle but there is no ChangeLog entry and the
> patch doesn't follow the GNU Coding Style: TABs instead of spaces, spaces
> before parentheses, etc. See the equivalent code in extract_bit_field_1.
> Moreover you need to properly test it on a mainstream big-endian platform.
Passes bootstrap and regression test powerpc64-linux.
--
Alan Modra
Australia Development Lab, IBM