This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove DWARF_OFFSET_SIZE, DWARF_INITIAL_LENGTH_SIZE
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: gcc-patches at gcc dot gnu dot org, Jason Merrill <jason at redhat dot com>
- Date: Mon, 12 Mar 2012 17:41:47 +0000 (UTC)
- Subject: Re: Remove DWARF_OFFSET_SIZE, DWARF_INITIAL_LENGTH_SIZE
- References: <ydd62e9kaqc.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On Mon, 12 Mar 2012, Rainer Orth wrote:
> With the IRIX port gone (shortly), there are no targets that define a
> non-default DWARF_OFFSET_SIZE or DWARF_INITIAL_LENGTH_SIZE any longer.
> I therefore propose to remove the code handling this.
As a *target macro* it makes sense to remove it - reomve it from
defaults.h, make it purely internal to dwarf2out.c. But I think it makes
sense to have it inside dwarf2out.c - to indicate that a particular "4" is
actually the size of an offset (which could be 8 if 64-bit DWARF were
generated) rather than some other source of the magic number "4" (in
general I think using meaningful names is better than such magic numbers,
especially given that in the DWARF specification this is not a constant
4).
--
Joseph S. Myers
joseph@codesourcery.com