This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, RFA] delete obsolete -madjust-unroll option for SH
Hi,
Richard Guenther <richard.guenther@gmail.com> wrote:
> On Sat, Mar 10, 2012 at 5:25 AM, Sandra Loosemore
> <sandra@codesourcery.com> wrote:
>> When I was working on cleanups to invoke.texi I noticed this bit in the
>> SH Options section:
>>
>> @item -madjust-unroll
>> @opindex madjust-unroll
>> Throttle unrolling to avoid thrashing target registers.
>> This option only has an effect if the GCC code base supports the
>> TARGET_ADJUST_UNROLL_MAX target hook.
>>
>> Well, the current manual is supposed to document what the current GCC
>> code base does, so I looked up this target hook and found it was deleted
>> in 2007 with a ChangeLog note that it has been dead since gcc 4.0.0.
>> However the command-line option is still present. ,A (B:-S
>>
>> Any reason why we should not delete this entirely, per the attached patch?
>> I haven't built/tested this (except for the manual) but can do that if the
>> patch isn't sufficiently obvious.
>
> Command-line options have to be preserved for backward-compatibility
> so old makefiles do not fail. Though the entry in the .opt file should match
>
> madjust-unroll
> Target Ignore
> Does nothing. Preserved for backward compatibility.
>
> The documentation can be removed, of course.
The patch is OK with the change suggested by Richard.
Thanks!
Regards,
kaz