This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch libffi, Darwin, PPC64] PR29152 (Darwin64 implementation), PR42387 (ppc va faults).
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: IainS <developer at sandoe-acoustics dot co dot uk>, Mike Stump <mrs at gcc dot gnu dot org>, Anthony Green <green at moxielogic dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, libffi-discuss at sourceware dot org
- Date: Wed, 7 Mar 2012 20:00:51 -0500
- Subject: Re: [Patch libffi, Darwin, PPC64] PR29152 (Darwin64 implementation), PR42387 (ppc va faults).
IainS,
Your patch completely broke libffi on AIX and your changes were not
Darwin-specific, despite Mike Stump's comment with his approval.
AIX shares ffi_darwin.c, as one should be able to see from all of the
AIX comments in the file.
aix_closure.S expects ffi_closure_helper_DARWIN to return the type, as
it previously did. So the following change completely breaks FFI on
AIX:
/* Tell ffi_closure_ASM to perform return type promotions. */
- return cif->rtype->type;
+ return cif->rtype;
- David