This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Do not use lang_hooks.types.type_for_size in signed_or_unsigned_type_for
- From: Michael Matz <matz at suse dot de>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 7 Mar 2012 15:24:20 +0100 (CET)
- Subject: Re: [PATCH] Do not use lang_hooks.types.type_for_size in signed_or_unsigned_type_for
- References: <alpine.LNX.2.00.1203071316470.18230@zhemvz.fhfr.qr>
Hi,
On Wed, 7 Mar 2012, Richard Guenther wrote:
> FAIL: gcc.dg/tree-ssa/pr31261.c scan-tree-dump-times original "return
> \\(char\\)
> -\\(unsigned char\\) c & 31;" 1
> FAIL: gcc.dg/tree-ssa/pr31261.c scan-tree-dump-times original "return
> \\(int\\)
> \\(12 - \\(unsigned int\\) d\\) & 7;" 1
>
> because we dump the unsigned type variant differently now. What do
> people think - adjust the testcase? Adjust how we pretty-print
> these non-standard integer types?
Adjusting the pretty printer would be nice anyway. Those <unnamed>:35
thingies hurt my eyes. Just printing int17 or uint18 would be perfectly
fine, with special casing of sizes that match the normal C types for
the target in question (so that input 'unsigned char' isn't converted to
'uint8' on one and 'uint16' on another target).
Ciao,
Michael.