Re: [PATCH, i386] RTM support

[Kirill Yukhin <kirill dot yukhin at gmail dot com>]

Updated patch attached.

>
> Technically OK, but let's wait for rth's comments about -mrtm option.
Thanks! Let's wait then.

>
> ? ? ? break;
> + ? ?case INT_FTYPE_VOID:
>
> Please add vertical space.
>
Added.

> +(define_expand "xbegin"
> + ?[(set (match_operand:SI 0 "register_operand" "=a")
> + ? (unspec_volatile:SI [(match_dup 1)] UNSPECV_XBEGIN))]
>
> Wrong indent.
Indented.

>
> +#ifdef __RTM__
> +#include <rtmintrin.h>
> +#endif
> +
> +#ifdef __RTM__
> +#include <xtestintrin.h>
> +#endif
>
> Probably we don't need two separate #ifdefs.
This is not as suitable, since next feature HLE has this intruction as
well, so condition for xtests will be OR-ed with __HLE__

>
> +/* Copyright (C) 2011 Free Software Foundation, Inc.
>
> Please update copyright year.
Fixed.

>
> +/* { dg-options "-mrtm -O0" } */
>
> +/* { dg-options "-mrtm -O0 -dp" } */
>
> No need to pass -O0 (default) and -dp.
>
Fixed.

ChangeLog entries were not touched.

Thanks, K

Attachment: rtm-4.gcc.patch
Description: Binary data