This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, i386] RTM support
- From: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Andi Kleen <andi at firstfloor dot org>
- Date: Mon, 5 Mar 2012 15:30:53 +0400
- Subject: Re: [PATCH, i386] RTM support
- Authentication-results: mr.google.com; spf=pass (google.com: domain of kirill.yukhin@gmail.com designates 10.216.139.25 as permitted sender) smtp.mail=kirill.yukhin@gmail.com; dkim=pass header.i=kirill.yukhin@gmail.com
- References: <CAGs3RftzMrnzFuDGv2RHvboA9utwncOuphB_G6ELDAFw-N3DNA@mail.gmail.com> <CAFULd4ajpdZiAxWNdxwr3Y9=0ThyReVBrLo1v+Awqy_auihwpA@mail.gmail.com>
Hello Uros,
> As the first remark, you don't have to add BLKmode memory clobbers.
> unspec_volatile RTX is considered to use and clobber all memory:
>
Thanks, fixed!
>
> But, I think that we want to use code label from the top of the false
> branch instead of ".+6". The question is, how to get it ...
Agreed, this seems not as nice, but still it works :)
I still do not understand, why not to put something like this?
"xbegin\t1f\n1:"
This is local label, which is not intercept others...
>
> Please use ix86_expand_setcc instead of opencoding sete insn.
>
Fixed!
Anything else?
Thanks, K