This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [4.8, C++ Patch] PR 52422

From: Jason Merrill <jason at redhat dot com>
To: Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Wed, 29 Feb 2012 20:38:05 -0500
Subject: Re: [4.8, C++ Patch] PR 52422
References: <4F4E11D5.8030408@oracle.com>

On 02/29/2012 06:53 AM, Paolo Carlini wrote:

Daniel noticed a couple other SFINAE issues, which I'm fixing in the
usual straightforward way. Tested x86_64-linux.

When fixing these things, please add checking for error_mark_node return as well. For instance, in this patch the calls to decay_conversion from build_conditional_expr_1 could return error_mark_node, in which case we want to return out of build_conditional_expr_1 as well. Similarly with the call in convert_like_real, and so on.

PS: while working on the patch, I noticed that a few functions, which in
the meanwhile acquired a tsubst_flags_t parameter, aren't fully
propagating it, are still passing tf_warning_or_error. Apparently a
clean-up is in order.

Please. :)

Jason

Follow-Ups:
- Re: [4.8, C++ Patch] PR 52422
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]