Re: [google/gcc-4_6_2-mobile] PATCH: PR other/46770: Replace .ctors/.dtors with .init_array/.fini_array on targets supporting them

[Jing Yu <jingyu at google dot com>]

Hi H.J.,

I think the patch itself is not enough.
I compared "AC_DEFUN([gcc_AC_INITFINI_ARRAY]" part (in acinclude.m4)
of gcc trunk and google/gcc-4_6_2-mobile, and found how
enable_initfini_array is
configured is different.

The patch breaks some of our tests. enable_initfini_array should be
disabled for cross compile by default. But it is not true in our
branch. Could you please point us all related patches?

Thanks,
Jing

On Mon, Feb 20, 2012 at 8:30 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sat, Feb 18, 2012 at 1:54 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> On Fri, Feb 17, 2012 at 05:20:02PM -0800, H.J. Lu wrote:
>>> This patch backports the fix from trunk:
>>>
>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46770
>>>
>>> for google/gcc-4_6_2-mobile branch. ?This is needed to support C++
>>> global constructors/destructiors on Android/x86. ?OK for
>>> google/gcc-4_6_2-mobile branch?
>>
>> Don't you want to backport also all the follow-ups on this?
>>
>
> The original patch works with cross compile since it is disabled by
> default. ?For native compile, it works with the default GNU assembler
> and linker. ?If there are additional failure for native compile, it should
> be disabled at configure time.
>
>
> --
> H.J.