This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[google/main] Check for cross-compilers in validate_failures.py (issue5674087)
- From: dougkwan at google dot com (Doug Kwan)
- To: reply at codereview dot appspotmail dot com,dnovillo at google dot com,gcc-patches at gcc dot gnu dot org
- Date: Fri, 17 Feb 2012 02:49:33 -0800 (PST)
- Subject: [google/main] Check for cross-compilers in validate_failures.py (issue5674087)
Hi Diego,
This patch fixes a problem of the validate_failures.py script that
it rejects cross compilers. I have tested it by running the script
in the build directory of gcc configure for arm-unknown-linux-gnueabi.
I also tested it on a native compiler for x86. This should go to both
google/main and trunk.
-Doug
2012-02-17 Doug Kwan <dougkwan@google.com>
* contrib/testsuite-management/validate_failures.py
(def GetMakefileValue): Check for cross compilers.
Index: contrib/testsuite-management/validate_failures.py
===================================================================
--- contrib/testsuite-management/validate_failures.py (revision 184327)
+++ contrib/testsuite-management/validate_failures.py (working copy)
@@ -146,7 +146,8 @@ def GetMakefileValue(makefile_name, value_name):
def ValidBuildDirectory(builddir, target):
if (not os.path.exists(builddir) or
not os.path.exists('%s/Makefile' % builddir) or
- not os.path.exists('%s/build-%s' % (builddir, target))):
+ (not os.path.exists('%s/build-%s' % (builddir, target)) and
+ not os.path.exists('%s/%s' % (builddir, target)))):
return False
return True
--
This patch is available for review at http://codereview.appspot.com/5674087