This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix up --enable-initfini-array autodetection in configure (PR bootstrap/50237)
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Richard Guenther <richard dot guenther at gmail dot com>
- Cc: Paolo Bonzini <bonzini at gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, Alexandre Oliva <aoliva at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 16 Feb 2012 21:33:24 +0100
- Subject: Re: [PATCH] Fix up --enable-initfini-array autodetection in configure (PR bootstrap/50237)
- References: <20120118232441.GO18768@tyan-ft48-01.lab.bos.redhat.com> <ydd62ftxhih.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <4F26CBFD.7060608@gnu.org> <yddwr7ouipv.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <CAFiYyc0FsVs_xoW4ydM-J0sD_LL7yzJ-vN9tccx6b-WJ+e3cFw@mail.gmail.com>
Richard Guenther <richard.guenther@gmail.com> writes:
> I'm not sure about the varasm.c change - it's definitely not a no-op
> (callback will be not set, and the flags will be different). Certainly
As I've demonstrated in my response to H.J., the effect with gas is none.
> the current code is inconsistent wrt the priority != DEFAULT_INIT_PRIORITY
> case, not sure why, but you don't make it consistent either because
> you don't change that case to SECTION_NOTYPE either. I'd be fine
I didn't find a need for that, but agree that the inconsistency is
disturbing. default_section_type_flags suggests that SECTION_NOTYPE
should be set for .init_array and friends, but it's only used by
get_named_section.
> with it with both calls using SECTION_NOTYPE, but would like to
> know what the callback difference is about.
I don't think the callback is needed, which is effectively a
printf ("\t.section\t.init_array");
Looking at it, this is e.g. wrong for Sun as on SPARC, which requires
the section name to be in double quotes.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University