This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch,AVR]: Built-in for non-contiguous port layouts
- From: "Weddington, Eric" <Eric dot Weddington at atmel dot com>
- To: "Georg-Johann Lay" <avr at gjlay dot de>, <gcc-patches at gcc dot gnu dot org>
- Cc: "Denis Chertykov" <chertykov at gmail dot com>
- Date: Tue, 14 Feb 2012 10:32:27 -0700
- Subject: RE: [Patch,AVR]: Built-in for non-contiguous port layouts
- References: <4F3933D9.7050308@gjlay.de>
> -----Original Message-----
> From: Georg-Johann Lay
> Sent: Monday, February 13, 2012 9:01 AM
> To: gcc-patches@gcc.gnu.org
> Cc: Weddington, Eric; Denis Chertykov
> Subject: [Patch,AVR]: Built-in for non-contiguous port layouts
>
> This patch set removes __builtin_avr_map8 __builtin_avr_map16
built-ins and
> implements a built-in __builtin_avr_insert_bits instead.
>
Hi Johann,
I'm just now starting to review this patch, but I have a quick
question...
In your avr_fold_builtin function you have switch (fcode) with only one
case (and a "default" that just breaks). Are you planning to add more
cases in the near future? If not, wouldn't it be better to just make it
an 'if' statement?
Thanks,
Eric