This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Add capability to contrib/compare_tests to handle directories
- From: Quentin Neill <quentin dot neill dot gnu at gmail dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 14 Feb 2012 10:41:27 -0600
- Subject: Re: PATCH: Add capability to contrib/compare_tests to handle directories
- References: <CAEhygDr2bLu5fGyeAxD=gsvfA9dz7tHE-XnndTDP5N4Augt1Sw@mail.gmail.com> <CAEhygDq1UOj94ttJ5qhyyB0b_BPurK32_Mqn6LWNx95FOxr5qg@mail.gmail.com> <4CD2433B-1994-4834-A595-131242428431@comcast.net> <CAEhygDpR0R8hw903LCys0m3AW0kvW+Egjjzbj=-7aWHgM-Q4xA@mail.gmail.com> <CAEhygDrtBbbQKQj4EVBrN5qZMru_+3Mbk+GinZ+yNdd3wc3Hyg@mail.gmail.com> <7F0115C8-1F88-4567-81A9-C8AEA5CF1B59@comcast.net> <CAEhygDrTfvQiHmqS=SaxEDFZ3D-r6oDrRCeszGX8pkTZ6hHRYA@mail.gmail.com>
On Tue, Feb 14, 2012 at 10:39 AM, Quentin Neill
<quentin.neill.gnu@gmail.com> wrote:
> On Sat, Feb 11, 2012 at 8:13 AM, Mike Stump <mikestump@comcast.net> wrote:
>> On Nov 4, 2011, at 8:23 PM, Quentin Neill wrote:
>>> My scenario about "ANY test results changed" is what I added with -strict.
>>> This patch concatenates the common .sum files before comparing.
>>
>> So, how exactly does this work for you:
>>
>> + ? ? ? ( for fname in `cat $lst5`; do cat $1/$fname; done ) >$sum1
>> + ? ? ? ( for fname in `cat $lst5`; do cat $2/$fname; done ) >$sum2
>> + ? ? ? echo "## ${CONFIG_SHELL-/bin/sh} $0 $strict $sum1 $sum2"
>> + ? ? ? ${CONFIG_SHELL-/bin/sh} $0 $strict $sum1 $sum2
>>
>> sum1 and sum2 appear to be variables that aren't set.
>
> Hi Mike,
>
> Thanks for the fix. ?This seemed familiar, and upon review it looks
> like I never committed this fix:
> http://gcc.gnu.org/ml/gcc-patches/2011-11/msg01194.html
>
>
> Do you prefer this patch with my original intent (declaring sum1/sum2
> with other tmps and removing the trap on line 52):
Horrible wording for the first patch description. How about:
"Do you prefer this patch with my original intent (declaring sum1/sum2
with other tmps, and removing those files in the trap on line 52):"
--
Quentin