This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch,AVR]: Clean up hard-coded SFR addresses
- From: "Weddington, Eric" <Eric dot Weddington at atmel dot com>
- To: "Georg-Johann Lay" <avr at gjlay dot de>, <gcc-patches at gcc dot gnu dot org>
- Cc: "Denis Chertykov" <chertykov at gmail dot com>
- Date: Fri, 3 Feb 2012 14:14:27 -0700
- Subject: RE: [Patch,AVR]: Clean up hard-coded SFR addresses
- References: <4F2C39AE.7030708@gjlay.de>
> -----Original Message-----
> From: Georg-Johann Lay [mailto:avr@gjlay.de]
> Sent: Friday, February 03, 2012 12:47 PM
> To: gcc-patches@gcc.gnu.org
> Cc: Denis Chertykov; Weddington, Eric
> Subject: [Patch,AVR]: Clean up hard-coded SFR addresses
>
> This patch removes the define_constants from avr.md:
> SREG_ADDR, SP_ADDR, RAMPZ_ADDR.
>
> The constants were not used in md directly and didn't take care of
afr_offset
> between RAM and I/O address.
>
> The replacement is a new structure avr_addr that holds RAM addresses
of
> respective SFRs and takes into account avr_current_arch->sfr_offset.
>
> sfr_offset is the same for all architectures, but that may change in
the
> future.
>
> Tested without regression.
>
> Ok for trunk?
In the struct avr_addr_t is there any reason why you didn't want to have
the low and high bytes of the stack pointer in a union with the full
stack pointer?
Eric