This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, go]: Do not panic in test/nilptr.go

From: Uros Bizjak <ubizjak at gmail dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: gcc-patches at gcc dot gnu dot org, gofrontend-dev at googlegroups dot com
Date: Wed, 1 Feb 2012 20:38:15 +0100
Subject: Re: [PATCH, go]: Do not panic in test/nilptr.go
References: <CAFULd4Y2HL373SCnob9Ppd0A7ezPzQ1Xku=TgjNjSPw==j-GWA@mail.gmail.com> <mcrobtjhdf2.fsf@dhcp-172-18-216-180.mtv.corp.google.com>

On Tue, Jan 31, 2012 at 8:36 PM, Ian Lance Taylor <iant@google.com> wrote:

>> There is no need for a panic in test/nilptr.go if array doesn't get
>> allocated in first 256 meg of memory. The compiler has nothing to do
>> with this.
>
> This is true but this does not seem like the right patch.

> I think I would prefer to just change go-test.exp to mark this test as
> xfail on Alpha. ?A patch to do that is preapproved.

Attached is the patch I have committed.

2012-02-01  Uros Bizjak  <ubizjak@gmail.com>

	* go.test/go-test.exp (go-gc-tests): xfail test/nilptr.go runtime
	test on alpha*-*-*.

Tested on alphaev68-pc-linux-gnu, committed to mainline SVN.

(BTW: Do you have any idea on what to do with excessive memory usage
in chan/select2.go? )

Uros.

Attachment: t.diff.txt
Description: Text document

Follow-Ups:
- Re: [PATCH, go]: Do not panic in test/nilptr.go
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]