This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR 51808 Heap allocate binding labels


Gerald Pfeifer wrote:
On Sun, 29 Jan 2012, Janne Blomqvist wrote:
Taking into account the suggestions by Tobias and Mikael, attached is
the patch I just committed. Thanks for the reviews!
I am now seeing the following bootstrap error on all my FreeBSD testers,
and this does not appear to be operating system-specific:

How and where was this patch tested?

I cannot comment on how Janne tested the patch, but I just did an update with a rebuild, and it survived building on x86-64-linux. While it was an incremental build (three stages, C++ compiler in stage 2/3), it worked - and, thus, assume that it should also survive a boot strap on that system.


Did you use a C++ compiler (default setting) or a C compiler (as often with cross build or with--disable-build-poststage1-with-cxx)?

I also wonder about the line numbers:

.../gcc-HEAD/gcc/fortran/decl.c:3828:23: error: invalid conversion from 'const char*' to 'char*' [-fpermissive]

On my system, that's:

3828 if (sym_name != NULL && has_name_equals == 0)
3829 *dest_label = IDENTIFIER_POINTER (get_identifier (sym_name));


Thus, having the line number 3828 is odd.

I have to think about line 3829 to understand whether there is an issue or not; one has "const char *sym_name" and "const char **dest_label", IDENTIFIER_POINTER returns (cast) a "const char*" and get_identifier takes a "const char *" as argument.

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]